obie
Obie
@dhh Have you or anyone else on the core team ever talked about pulling github.com/voxdolo/decent… into ActionController core? If so, why not?
clemensk
Clemens Kofler
@obie @dhh That would be *awesome* because the instance variable "magic" sucks anyway. :)
@obie @dhh That would be *awesome* because the instance variable "magic" sucks anyway. :)
dhh
DHH
@obie Hate that API with a passion, so no, it won't make it in. Far too little gain for the cost of indirection, imo.
@obie Hate that API with a passion, so no, it won't make it in. Far too little gain for the cost of indirection, imo.
dhh
DHH
@obie Certainly. But it wouldn't be the first time (see: testing w/ rspec or cucumber w/o customers).
@obie Certainly. But it wouldn't be the first time (see: testing w/ rspec or cucumber w/o customers).
buddhamagnet
Dave Goodchild
@dhh that doesn't mean everyone was wrong, just that you vetoed them, which is fine.
@dhh that doesn't mean everyone was wrong, just that you vetoed them, which is fine.
joshsusser
Josh Susser
@dhh @obie I don't know about the implementation of decent_exposure, but I hate how AP uses instvars to share state with views
@dhh @obie I don't know about the implementation of decent_exposure, but I hate how AP uses instvars to share state with views
tsaleh
Tammer Saleh
@joshsusser Agreed. descent_exposure might not be the right API, but copying ivars is the worst API of all /cc @dhh @obie
@joshsusser Agreed. descent_exposure might not be the right API, but copying ivars is the worst API of all /cc @dhh @obie
obie
Obie
@tsaleh @joshsusser @dhh @steveklabnik @supaspoida maybe core would be more amenable to a simple "let" implementation
@tsaleh @joshsusser @dhh @steveklabnik @supaspoida maybe core would be more amenable to a simple "let" implementation
dhh
DHH
@obie Right now, no. I consider the ivar copying method to be the best design of the available I've seen. Hoop-jumping to avoid @, meh.
@obie Right now, no. I consider the ivar copying method to be the best design of the available I've seen. Hoop-jumping to avoid @, meh.
dhh
DHH
@supaspoida Yes, I also think attr_accessor is a bad idea if you're just using it for internal access. Good for external exposure, though.
@supaspoida Yes, I also think attr_accessor is a bad idea if you're just using it for internal access. Good for external exposure, though.
dhh
DHH
@supaspoida But the way Action Pack is designed is to have templates be considered logical sub-methods of the controller. Thus ivar = great.
@supaspoida But the way Action Pack is designed is to have templates be considered logical sub-methods of the controller. Thus ivar = great.
supaspoida
Lar Van Der Jagt
@dhh that design decision is what we are taking issue with. decent_exposure doesn't fix the design, just works around it's flaws.
@dhh that design decision is what we are taking issue with. decent_exposure doesn't fix the design, just works around it's flaws.
dhh
DHH
@supaspoida Which is certainly fair. Rails is open and easy to extend, so have at it. Just explaining why it'll never be in core.
@supaspoida Which is certainly fair. Rails is open and easy to extend, so have at it. Just explaining why it'll never be in core.
